[
https://issues.apache.org/jira/browse/OOZIE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222469#comment-13222469
]
[email protected] commented on OOZIE-734:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4176/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
The KerberosHadoopAccessorService subclass was implemented as a separate
implementation to provide support for pre-UGI and UGI versions of Hadoop at the
same time. The DoAs/KerberosDoAs classes were there to make testcases run with
pre-UGI and UGI versions of Hadoop at the same time.
As the versions of Hadoop supported by trunk (3.2.0) all have UGI, we don't
need these classes anymore.
The KerberosHadoopAccessorService logic can be folded into the
HadoopAccessorService & the doAs classes can be removed.
This addresses bug OOZIE-734.
https://issues.apache.org/jira/browse/OOZIE-734
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/AuthHelper.java
1297142
trunk/core/src/main/java/org/apache/oozie/action/hadoop/DoAs.java 1297142
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1297142
trunk/core/src/main/java/org/apache/oozie/action/hadoop/KerberosAuthHelper.java
1297142
trunk/core/src/main/java/org/apache/oozie/action/hadoop/KerberosDoAs.java
1297142
trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
1297142
trunk/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java
1297142
trunk/core/src/main/resources/oozie-default.xml 1297142
trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java
1297142
trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java
1297142
trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java
1297142
trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java
1297142
trunk/core/src/test/java/org/apache/oozie/service/TestKerberosHadoopAccessorService.java
1297142
trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1297142
trunk/docs/src/site/twiki/AG_Install.twiki 1297142
trunk/docs/src/site/twiki/ENG_Building.twiki 1297142
trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java
1297142
Diff: https://reviews.apache.org/r/4176/diff
Testing
-------
Run all testcases successfully
Thanks,
Alejandro
> Simplify Kerberos/HadoopAccessorService code and remove Kerberos/DoAs code
> --------------------------------------------------------------------------
>
> Key: OOZIE-734
> URL: https://issues.apache.org/jira/browse/OOZIE-734
> Project: Oozie
> Issue Type: Improvement
> Components: core, security
> Affects Versions: 3.2.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 3.2.0
>
>
> The KerberosHadoopAccessorService subclass was implemented as a separate
> implementation to provide support for pre-UGI and UGI versions of Hadoop at
> the same time. The DoAs/KerberosDoAs classes were there to make testcases run
> with pre-UGI and UGI versions of Hadoop at the same time.
> As the versions of Hadoop supported by trunk (3.2.0) all have UGI, we don't
> need these classes anymore.
> The KerberosHadoopAccessorService logic can be folded into the
> HadoopAccessorService & the doAs classes can be removed.
> This will simplify the code and avoid a common source of confusion for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
