> On 2012-03-08 01:21:57, Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java, > > line 155 > > <https://reviews.apache.org/r/4236/diff/4/?file=88879#file88879line155> > > > > storing the HadoopAccessorService in a temp variable (such 'has') used > > it here. > > > > Same thing is done in previous method at line 139
ok will fix > On 2012-03-08 01:21:57, Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 181 > > <https://reviews.apache.org/r/4236/diff/4/?file=88881#file88881line181> > > > > namenode needs to be added into jobconf? it is added below, in line 195 > On 2012-03-08 01:21:57, Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java, > > line 274 > > <https://reviews.apache.org/r/4236/diff/4/?file=88883#file88883line274> > > > > These tree lines of code is being used many places. Can't we make it a > > new utility method and call it from every places? thought about that possibility, with this patch I just wanted to get things correct all over and then look for patterns to simplify/cleanup. > On 2012-03-08 01:21:57, Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java, > > line 82 > > <https://reviews.apache.org/r/4236/diff/4/?file=88889#file88889line82> > > > > same here. create a utility method and call it. same comment as before. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4236/#review5699 ----------------------------------------------------------- On 2012-03-08 00:29:07, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4236/ > ----------------------------------------------------------- > > (Updated 2012-03-08 00:29:07) > > > Review request for oozie. > > > Summary > ------- > > First patch is OOZIE-744 > Second patch is OOZIE-744 + OOZIE-745 > Third patch is OOZIE-744 + OOZIE-745 + OOZIE-746 > > > This addresses bugs OOZIE-744, OOZIE-745 and OOZIE-746. > https://issues.apache.org/jira/browse/OOZIE-744 > https://issues.apache.org/jira/browse/OOZIE-745 > https://issues.apache.org/jira/browse/OOZIE-746 > > > Diffs > ----- > > trunk/core/src/main/conf/hadoop-config.xml 1298218 > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1298218 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java > 1298218 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1298218 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1298218 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1298218 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1298218 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java > 1298218 > > trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1298218 > trunk/core/src/main/java/org/apache/oozie/util/JobUtils.java 1298218 > trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1298218 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java > 1298218 > > trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java > 1298218 > trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 1298218 > trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1298218 > > trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java > 1298218 > > Diff: https://reviews.apache.org/r/4236/diff > > > Testing > ------- > > run all tests against Hadoop 1 > > built deployed Oozie and submitted a MR WF against Hadoop 1 and Hadoop 0.23 > > > Thanks, > > Alejandro > >
