----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4222/#review5707 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/4222/#comment12443> Line 323-330 and line 333-340 look similar. is it possible to create a method and invoke it from the same place. trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java <https://reviews.apache.org/r/4222/#comment12445> how to identify this ${func(), func2()}? that means in one ${ } there are multiple functions. trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java <https://reviews.apache.org/r/4222/#comment12444> is it possible to add one/two unit test case for this new method in TestELEvaluator.jav? Both cases +ve and -ve. This is a critical pieces, hence asking to be more cautious. - Mohammad On 2012-03-08 08:19:24, Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4222/ > ----------------------------------------------------------- > > (Updated 2012-03-08 08:19:24) > > > Review request for oozie. > > > Summary > ------- > > checkMultipleTimeInstances doesn't work for EL extensions. EX: > ${coord:formatTime(coord:current(0),'yyyy-MM-dd')} > > > This addresses bug OOZIE-675. > https://issues.apache.org/jira/browse/OOZIE-675 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1297367 > trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java 1297367 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 1297367 > trunk/core/src/test/resources/coord-multiple-output-instance4.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/4222/diff > > > Testing > ------- > > New test case added to TestCoordSubmitXCommand.java for verifying the changes > > > Thanks, > > Srikanth > >
