-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4277/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

removing not-NULL checks and setting when NULL. 

Most of the places this is done to seed the conf to get a FileSystem/JobClient 
from the HadoopAccessorService.


This addresses bug OOZIE-752.
    https://issues.apache.org/jira/browse/OOZIE-752


Diffs
-----

  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
1299069 
  
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java
 1299069 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 1299069 
  
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
 1299069 
  trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1299069 
  trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
1299069 
  trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java 
1299069 
  trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 
1299069 
  trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1299069 
  trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1299069 
  trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 
1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java
 1299069 
  trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1299069 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java
 1299069 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 
1299069 
  
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java
 1299069 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 
1299069 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
1299069 
  
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java
 1299069 
  
trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 
1299069 
  
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
 1299069 
  trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 
1299069 
  
trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 
1299069 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 
1299069 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 
1299069 
  trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 
1299069 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1299069 

Diff: https://reviews.apache.org/r/4277/diff


Testing
-------

run all tests successfully. build/installed and run  job to verify


Thanks,

Alejandro

Reply via email to