[
https://issues.apache.org/jira/browse/OOZIE-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226659#comment-13226659
]
[email protected] commented on OOZIE-752:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4277/#review5813
-----------------------------------------------------------
Ship it!
+1
- Mohammad
On 2012-03-09 21:51:11, Alejandro Abdelnur wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4277/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-09 21:51:11)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. removing not-NULL checks and setting when NULL.
bq.
bq. Most of the places this is done to seed the conf to get a
FileSystem/JobClient from the HadoopAccessorService.
bq.
bq.
bq. This addresses bug OOZIE-752.
bq. https://issues.apache.org/jira/browse/OOZIE-752
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1299069
bq.
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java
1299069
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
1299069
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1299069
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1299069
bq.
trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java
1299069
bq.
trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java
1299069
bq.
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
1299069
bq. trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java
1299069
bq. trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java
1299069
bq. trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java
1299069
bq. trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java
1299069
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java
1299069
bq. trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java
1299069
bq. trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java
1299069
bq. trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java
1299069
bq. trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java
1299069
bq.
bq. Diff: https://reviews.apache.org/r/4277/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. run all tests successfully. build/installed and run job to verify
bq.
bq.
bq. Thanks,
bq.
bq. Alejandro
bq.
bq.
> if group.name/oozie.job.acl is not defined in job.properties job submission
> fails
> ---------------------------------------------------------------------------------
>
> Key: OOZIE-752
> URL: https://issues.apache.org/jira/browse/OOZIE-752
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 3.2.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 3.2.0
>
>
> The new ACL model makes the group/acl optional, thus being NULL.
> There are places in the code where it is checked the group should not be NULL.
> There are places in the code where a NULL group is being set in Configuration
> and this throws a exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
