[ 
https://issues.apache.org/jira/browse/OOZIE-754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227986#comment-13227986
 ] 

[email protected] commented on OOZIE-754:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4285/#review5858
-----------------------------------------------------------

Ship it!


+1 shop it after addressing feedback.


trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/4285/#comment12762>

    remove or modify java doc.



trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/4285/#comment12755>

    space


- Angelo K.


On 2012-03-11 16:39:58, Alejandro Abdelnur wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4285/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-11 16:39:58)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  OOZIE-754 removing parameter group from HadoopAccessorService
bq.  
bq.  this param/value is never used.
bq.  ----
bq.  OOZIE-755 remove hadoop.job.ugi and kerberos principal hardcoded injections
bq.  
bq.  The hadoop.job.ugi was being set for Hadoop 0.20 an earlier versions. It 
is of now use nowadays. 
bq.  
bq.  The Kerberos principals were injected because certain versions of hadoop 
didn't have them as default this is actually a bug as the injected value is 
hardcoded. Given that now Hadoop configurations per cluster can be set in the 
HadoopAccessor, if needed, this properties should be set there.
bq.  
bq.  
bq.  This addresses bugs OOZIE-754 and OOZIE-755.
bq.      https://issues.apache.org/jira/browse/OOZIE-754
bq.      https://issues.apache.org/jira/browse/OOZIE-755
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java
 1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java
 1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
 1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 
1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java 
1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 
1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java 
1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 
1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java 
1299383 
bq.    
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 
1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java 
1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/util/JobUtils.java 1299383 
bq.    trunk/core/src/main/java/org/apache/oozie/util/PropertiesUtils.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java
 1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunCommand.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunCommand.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java
 1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
 1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 
1299383 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 
1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1299383 
bq.    trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1299383 
bq.    trunk/minitest/src/test/java/org/apache/oozie/test/WorkflowTest.java 
1299383 
bq.  
bq.  Diff: https://reviews.apache.org/r/4285/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  run successfully all test cases against Hadoop 1 JARs
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alejandro
bq.  
bq.


                
> remove use of group from HadoopAccessor
> ---------------------------------------
>
>                 Key: OOZIE-754
>                 URL: https://issues.apache.org/jira/browse/OOZIE-754
>             Project: Oozie
>          Issue Type: Task
>          Components: core
>    Affects Versions: 3.2.0
>            Reporter: Alejandro Abdelnur
>             Fix For: 3.2.0
>
>
> this has never been used

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to