-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4306/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Oozie's docs have:
{quote}=oozie.email.from.address= - The from address to be used for mailing all
emails (oozie@localhost by default). {quote}
(From
http://incubator.apache.org/oozie/docs/3.1.3/docs/DG_EmailActionExtension.html)
However, the code does not seem to use a default when loading the prop from the
Oozie conf. Thus if someone does not specify it, it causes an NPE when it tries
to from a fromAddress object later.
Same applies to:
{quote}oozie.email.smtp.host - The host where the email action may find the
SMTP server (localhost by default). {quote}
This addresses bug OOZIE-759.
https://issues.apache.org/jira/browse/OOZIE-759
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
1300071
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java
1300071
Diff: https://reviews.apache.org/r/4306/diff
Testing
-------
Modified test case to do mix of default loading and config setting. No behavior
changed, existing test too passes with patch.
Thanks,
Harsh
