> On 2012-03-16 04:24:12, Alejandro Abdelnur wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java, 
> > line 170
> > <https://reviews.apache.org/r/4378/diff/1/?file=92894#file92894line170>
> >
> >     Shouldn't the message just be 'Workflow submitted'? the loginfo will 
> > have the ID

The ID was not getting added through the loginfo. It is due to the way a 
SubmitXCommand constructor is invoked, it does not have a jobID at that point 
and does not override 'loadState' like other start commands. So this statement 
is added.


- Mona


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4378/#review6021
-----------------------------------------------------------


On 2012-03-16 04:19:15, Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4378/
> -----------------------------------------------------------
> 
> (Updated 2012-03-16 04:19:15)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> The job Id was not being recorded to oozie.log if the job was submited with 
> option -submit instead of -run. This helps filtering through the logs for 
> submitted jobs.
> 
> Since this is a logging addition, no unit tests applicable. 
> 
> 
> This addresses bug OOZIE-758.
>     https://issues.apache.org/jira/browse/OOZIE-758
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 
> 1301249 
> 
> Diff: https://reviews.apache.org/r/4378/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mona
> 
>

Reply via email to