[
https://issues.apache.org/jira/browse/OOZIE-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238808#comment-13238808
]
[email protected] commented on OOZIE-739:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4204/#review6364
-----------------------------------------------------------
Few comments.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/4204/#comment13807>
Move to the previous line as per Java coding convention
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/4204/#comment13805>
Can you add a note on why the CommandException is being thrown?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/4204/#comment13816>
Will be good to add descriptive error message in addition to chaining the
exception.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/4204/#comment13809>
The formatting is off for the comments and the method by a couple of tabs.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/4204/#comment13810>
Can you add a note on strings that are discarded?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/4204/#comment13811>
The formatting is off for the comments and the method by a couple of tabs.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/4204/#comment13808>
Resetting (not resting)
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/4204/#comment13812>
The formatting is off for the by a tab.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/4204/#comment13815>
If no exception is thrown then the test case will pass. In order to catch
this, add a fail() immediately after the call to pathExists
- Santhosh
On 2012-03-23 16:34:50, Mohamed Battisha wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4204/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 16:34:50)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. a coord action fails because the uri points to a namenode that is not in
bq. whitelist. the E0901 error shows in the oozie.log. but the error code and
error
bq. message does not display in oozie job -info action# -verbose. for example,
bq.
bq. $ oozie job -log 0000028-100625200833755-oozie-oozi-C
bq. ...
bq. 2010-06-28 18:50:56,502 DEBUG CoordActionInputCheckCommand:544 -
USER[mchiang]
bq. GROUP[users] TOKEN[] APP[coord-21-20]
JOB[0000028-100625200833755-oozie-oozi-C]
bq. ACTION[-] checking for the file
bq. 2010-06-28 18:50:56,502 WARN CoordActionInputCheckCommand:541 -
USER[mchiang]
bq. GROUP[users] TOKEN[] APP[coord-21-20]
JOB[0000028-100625200833755-oozie-oozi-C]
bq. ACTION[-] 0000028-100625200833755-oozie-oozi-C@1: Exception occurs:
bq. java.io.IOException: org.apache.oozie.service.HadoopAccessorException:
E0901:
bq. Namenode [XXXXXX:8020] not allowed, not in Oozies
bq. whitelist STORE is active true
bq. java.io.IOException: org.apache.oozie.service.HadoopAccessorException:
E0901:
bq. Namenode [XXXXX:8020] not allowed, not in Oozies
bq. whitelist
bq. ...
bq.
bq.
bq. $ oozie job -info 0000028-100625200833755-oozie-oozi-C@1 -verbose
bq. ID : 0000028-100625200833755-oozie-oozi-C@1
bq.
------------------------------------------------------------------------------------------------------------------------------------
bq. Action Number : 1
bq. Console URL : -
bq. Error Code : -
bq. Error Message : -
bq. External ID : -
bq. External Status : -
bq. Job ID : 0000028-100625200833755-oozie-oozi-C
bq. Tracker URI : -
bq. Created : 2010-06-28 18:50
bq. Status : WAITING
bq. Last Modified : 2010-06-28 18:50
bq. Missing Dependencies :
bq. hdfs://XXXXXX:8020/user/mchiang/coord-input/2010/06/11/01/00/_SUCCESS
bq.
------------------------------------------------------------------------------------------------------------------------------------
bq.
bq.
bq. This addresses bug OOZIE-739.
bq. https://issues.apache.org/jira/browse/OOZIE-739
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
1303467
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
1303467
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
1304465
bq.
bq. Diff: https://reviews.apache.org/r/4204/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohamed
bq.
bq.
> a coord action fails because the uri points to a namenode that is not in
> whitelist. the E0901 error shows in the oozie.log, but not written to the
> database
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-739
> URL: https://issues.apache.org/jira/browse/OOZIE-739
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
> Affects Versions: 3.2.0
> Reporter: Mohamed Battisha
> Assignee: Mohamed Battisha
> Priority: Minor
> Fix For: 3.2.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> a coord action fails because the uri points to a namenode that is not in
> whitelist. the E0901 error shows in the oozie.log. but the error code and
> error
> message does not display in oozie job -info action# -verbose. for example,
> $ oozie job -log 0000028-100625200833755-oozie-oozi-C
> ...
> 2010-06-28 18:50:56,502 DEBUG CoordActionInputCheckCommand:544 - USER[mchiang]
> GROUP[users] TOKEN[] APP[coord-21-20]
> JOB[0000028-100625200833755-oozie-oozi-C]
> ACTION[-] checking for the file
> 2010-06-28 18:50:56,502 WARN CoordActionInputCheckCommand:541 - USER[mchiang]
> GROUP[users] TOKEN[] APP[coord-21-20]
> JOB[0000028-100625200833755-oozie-oozi-C]
> ACTION[-] 0000028-100625200833755-oozie-oozi-C@1: Exception occurs:
> java.io.IOException: org.apache.oozie.service.HadoopAccessorException: E0901:
> Namenode [XXXXX:8020] not allowed, not in Oozies
> whitelist STORE is active true
> java.io.IOException: org.apache.oozie.service.HadoopAccessorException: E0901:
> Namenode [XXXXX:8020] not allowed, not in Oozies
> whitelist
> ...
> $ oozie job -info 0000028-100625200833755-oozie-oozi-C@1 -verbose
> ID : 0000028-100625200833755-oozie-oozi-C@1
> ------------------------------------------------------------------------------------------------------------------------------------
> Action Number : 1
> Console URL : -
> Error Code : -
> Error Message : -
> External ID : -
> External Status : -
> Job ID : 0000028-100625200833755-oozie-oozi-C
> Tracker URI : -
> Created : 2010-06-28 18:50
> Status : WAITING
> Last Modified : 2010-06-28 18:50
> Missing Dependencies :
> hdfs://XXXXX/_SUCCESS
> ------------------------------------------------------------------------------------------------------------------------------------
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
