----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4554/#review6527 -----------------------------------------------------------
Ship it! +1 - Angelo K. On 2012-03-29 12:45:11, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4554/ > ----------------------------------------------------------- > > (Updated 2012-03-29 12:45:11) > > > Review request for oozie. > > > Summary > ------- > > Similar to hadoop configs per cluster, Oozie should support default action > configurations per cluster. > > This default config per action per cluster mechanism would act as defaults > for the action configuration section enabling things like: > > * defining a special queue for launcher jobs > * setting properties required to tune pig/hive etc > > It should load/work in identical way as the hadoop configurations but instead > using just a 'host:name' key it would use a composed key 'host:name + > action-type' > > If the ACTION.xml file does not exist, then there are not defaults values. > > The default value for the action.configurations is identical to the > hadoop.configurations: *=hadoop-conf. It is a different property to allow > pointing to the HADOOP conf/ dir for hadoop configurations and to an Oozie > dir for action configurations (not to pollute Hadoop confs) > > > This addresses bug OOZIE-792. > https://issues.apache.org/jira/browse/OOZIE-792 > > > Diffs > ----- > > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 1306811 > trunk/core/src/main/resources/oozie-default.xml 1306811 > > trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 1306811 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 1306811 > > trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java > 1306811 > trunk/core/src/test/resources/test-action-config.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/4554/diff > > > Testing > ------- > > * Run all testcases successfully with Hadoop 1 and Hadoop 0.23 > > * Deployed Oozie, run examples, added actions configs values, and verified > the actions gets the values. > > > Thanks, > > Alejandro > >
