----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4476/#review6646 -----------------------------------------------------------
Ship it! +1... minor comment about exception handling - Virag On 2012-03-29 23:49:15, Mohamed Battisha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4476/ > ----------------------------------------------------------- > > (Updated 2012-03-29 23:49:15) > > > Review request for oozie. > > > Summary > ------- > > Currently there is no limit to the xml file that is submitted by the user. > submitting a big file make cause some issues > > > This addresses bug oozie-741. > https://issues.apache.org/jira/browse/oozie-741 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/ErrorCode.java > 1307166 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1307166 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml > 1307166 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1307166 > > Diff: https://reviews.apache.org/r/4476/diff > > > Testing > ------- > > New test cases are added > > > Thanks, > > Mohamed > >
