-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4637/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

The HadoopAccessorService has 2 createFileSystem() methods, one that takes 
(user,conf) and extract the FS URI from the fs.default.name property in the 
conf and other that takes (user,uri,conf).

The (user,conf) signature should be remove forcing to using the explicit URI of 
the fs to use, thus ensuring we don't have a bogus/wrong conf with an invalid 
dfs.default.name property.

This will help when OOZIE-477 gets in to ensure that we are always stating 
explicitly which FS we want a handle for, without assuming the conf has the 
correct default.


This addresses bug OOZIE-803.
    https://issues.apache.org/jira/browse/OOZIE-803


Diffs
-----

  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
1309392 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 
1309392 
  trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 
1309392 
  trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1309392 
  trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309392 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
 1309392 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
 1309392 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java
 1309392 
  
trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java
 1309392 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 
1309392 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 
1309392 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
1309392 
  
trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 
1309392 
  
trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 
1309392 
  
trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java
 1309392 
  trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 
1309392 
  trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 
1309392 
  trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 
1309392 

Diff: https://reviews.apache.org/r/4637/diff


Testing
-------

runs all testcases (together with OOZIE-802 I'm able to run successfully all 
testcases with Hadoop 0.23)


Thanks,

Alejandro

Reply via email to