[
https://issues.apache.org/jira/browse/OOZIE-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246514#comment-13246514
]
[email protected] commented on OOZIE-803:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4637/#review6689
-----------------------------------------------------------
Ship it!
+1
- Mayank
On 2012-04-04 14:16:37, Alejandro Abdelnur wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4637/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-04 14:16:37)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The HadoopAccessorService has 2 createFileSystem() methods, one that takes
(user,conf) and extract the FS URI from the fs.default.name property in the
conf and other that takes (user,uri,conf).
bq.
bq. The (user,conf) signature should be remove forcing to using the explicit
URI of the fs to use, thus ensuring we don't have a bogus/wrong conf with an
invalid dfs.default.name property.
bq.
bq. This will help when OOZIE-477 gets in to ensure that we are always stating
explicitly which FS we want a handle for, without assuming the conf has the
correct default.
bq.
bq.
bq. This addresses bug OOZIE-803.
bq. https://issues.apache.org/jira/browse/OOZIE-803
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1309392
bq.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java
1309392
bq.
trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
1309392
bq. trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java
1309392
bq. trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309392
bq.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java
1309392
bq. trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java
1309392
bq.
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java
1309392
bq. trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java
1309392
bq.
bq. Diff: https://reviews.apache.org/r/4637/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. runs all testcases (together with OOZIE-802 I'm able to run successfully
all testcases with Hadoop 0.23)
bq.
bq.
bq. Thanks,
bq.
bq. Alejandro
bq.
bq.
> Remove HadoopAccessorService createFileSystem() method that takes config only
> -----------------------------------------------------------------------------
>
> Key: OOZIE-803
> URL: https://issues.apache.org/jira/browse/OOZIE-803
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: 3.2.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 3.2.0
>
>
> The HadoopAccessorService has 2 createFileSystem() methods, one that takes
> (user,conf) and extract the FS URI from the fs.default.name property in the
> conf and other that takes (user,uri,conf).
> The (user,conf) signature should be remove forcing to using the explicit URI
> of the fs to use, thus ensuring we don't have a bogus/wrong conf with an
> invalid dfs.default.name property.
> This will help when OOZIE-477 gets in to ensure that we are always stating
> explicitly which FS we want a handle for, without assuming the conf has the
> correct default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
