----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4715/#review6962 -----------------------------------------------------------
Ship it! +1 committing - Mohammad On 2012-04-14 03:17:18, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4715/ > ----------------------------------------------------------- > > (Updated 2012-04-14 03:17:18) > > > Review request for oozie. > > > Summary > ------- > > Subworkflow AE needs to account for assigning group/acl name to child wf if > parent has it. <propagate-configuration> should not be needed for something > as basic as group/acl name. > > Example output: > > sub workflow child workflow job does not have the group name. > > $ oozie jobs -len 2 > Job ID App Name Status User Group Started Ended > ----------------------------------------------------------------------------------------------------------- > 0002-oozie-oozi-W child-wf KILLED joe - 2012-03-30 21:28 2012-03-30 21:31 > ----------------------------------------------------------------------------------------------------------- > 0001-oozie-oozi-W parent-wf KILLED joe users 2012-03-30 21:28 2012-03-30 21:31 > > > This addresses bug OOZIE-813. > https://issues.apache.org/jira/browse/OOZIE-813 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 1325599 > > trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > 1325599 > > Diff: https://reviews.apache.org/r/4715/diff > > > Testing > ------- > > yes. unit test for both negative and positive cases > > > Thanks, > > Mona > >
