[ 
https://issues.apache.org/jira/browse/OOZIE-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261087#comment-13261087
 ] 

[email protected] commented on OOZIE-820:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4863/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

For shell action, the env-var's value is truncated by =. for example, the shell 
action in
workflow.xml:
<shell xmlns="uri:oozie:shell-action:0.1">
... ...
<exec>${SCRIPT}</exec>
<env-var>myVar="v=123;t=456;s=abc--"</env-var>
<file>${SCRIPT}#${SCRIPT}</file>
<capture-output/>

then the ${myVar} becomes: 
myVar="v

expect it to be: ${myVar} equals v=123;t=456;s=abc--


Minor change required in ShellMain to limit string splitting to 1 occurrence of 
regex "="


This addresses bug OOZIE-820.
    https://issues.apache.org/jira/browse/OOZIE-820


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java 
1326832 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
 1326832 

Diff: https://reviews.apache.org/r/4863/diff


Testing
-------

unit tests pass


Thanks,

Mona


                
> Shell action to support env-var value with = sign
> -------------------------------------------------
>
>                 Key: OOZIE-820
>                 URL: https://issues.apache.org/jira/browse/OOZIE-820
>             Project: Oozie
>          Issue Type: Bug
>          Components: action
>    Affects Versions: 3.2.0
>            Reporter: Mona Chitnis
>            Assignee: Mona Chitnis
>              Labels: oozie
>             Fix For: 3.2.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> For shell action, the env-var's value is truncated by =. for example, the 
> shell action in
> workflow.xml:
> <shell xmlns="uri:oozie:shell-action:0.1">
> ... ...
> <exec>${SCRIPT}</exec>
> <env-var>myVar="v=123;t=456;s=abc--"</env-var>
> <file>${SCRIPT}#${SCRIPT}</file>
> <capture-output/>
> then the ${myVar} becomes: 
> myVar="v
> expect it to be: ${myVar} equals v=123;t=456;s=abc--

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to