----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4863/#review7244 -----------------------------------------------------------
Ship it! +1 - Santhosh On 2012-04-24 22:22:06, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4863/ > ----------------------------------------------------------- > > (Updated 2012-04-24 22:22:06) > > > Review request for oozie. > > > Summary > ------- > > For shell action, the env-var's value is truncated by =. for example, the > shell action in > workflow.xml: > <shell xmlns="uri:oozie:shell-action:0.1"> > ... ... > <exec>${SCRIPT}</exec> > <env-var>myVar="v=123;t=456;s=abc--"</env-var> > <file>${SCRIPT}#${SCRIPT}</file> > <capture-output/> > > then the ${myVar} becomes: > myVar="v > > expect it to be: ${myVar} equals v=123;t=456;s=abc-- > > > Minor change required in ShellMain to limit string splitting to 1 occurrence > of regex "=" > > > This addresses bug OOZIE-820. > https://issues.apache.org/jira/browse/OOZIE-820 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java > 1326832 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1326832 > > Diff: https://reviews.apache.org/r/4863/diff > > > Testing > ------- > > unit tests pass > > > Thanks, > > Mona > >
