[
https://issues.apache.org/jira/browse/OOZIE-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263947#comment-13263947
]
[email protected] commented on OOZIE-815:
-----------------------------------------------------
bq. On 2012-04-27 20:05:47, Mona Chitnis wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java,
line 62
bq. > <https://reviews.apache.org/r/4794/diff/2/?file=103222#file103222line62>
bq. >
bq. > Should this include missing dependencies?
yes good catch, missing deps and created conf are required..thanks
bq. On 2012-04-27 20:05:47, Mona Chitnis wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java,
line 139
bq. > <https://reviews.apache.org/r/4794/diff/2/?file=103224#file103224line139>
bq. >
bq. > Why not CoordActionGetForInputCheck here?
CoordActionGetForInputCheck is used by InputCheck cmd
bq. On 2012-04-27 20:05:47, Mona Chitnis wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java,
line 63
bq. > <https://reviews.apache.org/r/4794/diff/2/?file=103246#file103246line63>
bq. >
bq. > What is the advantage of creating action bean objects here rather
than having the query return beans itself?
query cant return the entire bean as only some of the columns are returned.
query returns object[] from which bean needs to be constructed
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4794/#review7319
-----------------------------------------------------------
On 2012-04-19 18:15:29, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4794/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-19 18:15:29)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-815
bq.
bq. Some changes related to rerun and log queries are pending. Please review
the patch. In meanwhile, I will work on completing the patch.
bq.
bq.
bq. This addresses bug oozie-815.
bq. https://issues.apache.org/jira/browse/oozie-815
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
1327678
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionCheckXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInfoXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionReadyXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionTimeOutXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForInputCheckJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForRerunJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionUpdateForStartJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetByLastModifiedTimeJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForJobJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsRunningGetJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsSubsetGetForJobJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionIdsForDateRangeJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetReadyActionsJPAExecutor.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java
1327678
bq. trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java
1327678
bq.
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetByLastModifiedTimeJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForCheckJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInfoJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForStartJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForTimeoutJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForInputCheckJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForRerunJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateForStartJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionIdsForDatesJPAExecutor.java
PRE-CREATION
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java
1327678
bq. trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java
1327678
bq.
trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java
1327678
bq.
bq. Diff: https://reviews.apache.org/r/4794/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran the test suite and also the cron, mapreduce example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Remove select * from queries related to coord action
> ----------------------------------------------------
>
> Key: OOZIE-815
> URL: https://issues.apache.org/jira/browse/OOZIE-815
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
> Assignee: Virag Kothari
>
> Currently oozie brings all actions into memory when certain cmds are run. If
> a coordjob has thousands of actions, clicking the job multiple times on
> webconsole will bring huge number of actions in memory causing OOM.
> Oozie-587 removes select * queries used in statustransitservice and suspend,
> resume, kill cmds. This jira proposes to remove select * from other queries
> like jobinfo and other cmds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
