[ 
https://issues.apache.org/jira/browse/OOZIE-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264072#comment-13264072
 ] 

[email protected] commented on OOZIE-783:
-----------------------------------------------------



bq.  On 2012-04-27 22:02:08, Alejandro Abdelnur wrote:
bq.  > Virag,
bq.  > 
bq.  > I know you've done  tons of work here converting all testcase to junit4 
annotations.
bq.  > 
bq.  > While that is quite nice, I have the following concern.
bq.  > 
bq.  > Because all tescases have changed in several places (signatures), 
backporting fixes to 3.1 and 3.2 branches from trunk will require a lot of work 
because patches will never apply cleanly.
bq.  > 
bq.  > I'd suggest the following approach:
bq.  > 
bq.  > * Upgrade to junit4
bq.  > * leave all junit3 testcases untouch
bq.  > * retrofit XTestCase & XFSTestCase so the work both with junit3 and 
junit4 testcases
bq.  > * new testcases would be done using junit4
bq.  > 
bq.  > What do you think of this approach?
bq.  
bq.  Virag Kothari wrote:
bq.      The original idea to upgrade everything was to run testcases in 
parallel. However, there are issues running things in parallel which are 
discussed in oozie-784. Until those issues are resolved, I agree we should not 
touch existing test cases as backporting might be a problem.
bq.      
bq.      Also, once 3.1 and 3.2 become stable, we can think of upgrading 
everything as backporting may be minimum.
bq.      
bq.

gr8, will you be working on an updated patch?


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review7329
-----------------------------------------------------------


On 2012-04-04 03:58:07, Virag Kothari wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4618/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-04 03:58:07)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Changes:
bq.  1) @Test, @After, @Before annotations added
bq.  2) extends TestCase removed
bq.  3) Imports added (Some of the imports are unused, but they can be removed 
together in a separate patch)
bq.  4) Junit 4 has a different way to obtain testcase method name; added in 
XTestCase  
bq.  
bq.  
bq.  This addresses bug oozie-783.
bq.      https://issues.apache.org/jira/browse/oozie-783
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1309227 
bq.    trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java
 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java
 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java
 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java
 1309227 
bq.    trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java
 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java
 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 
1309227 
bq.    trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 
1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
 1309227 
bq.    
trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java
 1309227 
bq.    trunk/pom.xml 1309227 
bq.    
trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java
 1309227 
bq.  
bq.  Diff: https://reviews.apache.org/r/4618/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran bin/mkdistro
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Virag
bq.  
bq.


                
> Upgrade to junit4
> -----------------
>
>                 Key: OOZIE-783
>                 URL: https://issues.apache.org/jira/browse/OOZIE-783
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Virag Kothari
>
> Following things are required from migrating:
> 1) Add @Test annotation to each test
> 2) "extends TestCase" should be removed in XTestCase
> 3) @Before and @After annotations for setUp() and tearDown()
>    @Before
>    public void setUp() throws Exception { }
>    @After
>    public void tearDown() throws Exception { }
> 4) Some changes to imports required 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to