----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4998/#review7520 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java <https://reviews.apache.org/r/4998/#comment16653> question about "str[0].trim().length() > 0": so if the first line is empty, it will not even try in other lines or values. According to AG_INSTall twiki, the empty line will be skipped. trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java <https://reviews.apache.org/r/4998/#comment16652> Can we add some debugging for this exception? - Mohammad On 2012-05-03 20:28:59, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4998/ > ----------------------------------------------------------- > > (Updated 2012-05-03 20:28:59) > > > Review request for oozie. > > > Summary > ------- > > adds the option to specify a list of admin groups to check users for admin > privileges instead of using the adminusers.txt file. the adminusers.txt file > option is still available if the admin groups list is not specified. > > > This addresses bug OOZIE-773. > https://issues.apache.org/jira/browse/OOZIE-773 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java > 1333606 > > trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java > 1333606 > trunk/docs/src/site/twiki/AG_Install.twiki 1333606 > > Diff: https://reviews.apache.org/r/4998/diff > > > Testing > ------- > > run all tests successfully > > > Thanks, > > Alejandro > >
