[ 
https://issues.apache.org/jira/browse/OOZIE-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267821#comment-13267821
 ] 

[email protected] commented on OOZIE-773:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4998/#review7520
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java
<https://reviews.apache.org/r/4998/#comment16653>

    question about "str[0].trim().length() > 0":
    so if the first line is empty, it will not even try in other lines or 
values.
    
    According to AG_INSTall twiki, the empty line will be skipped.
    



trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java
<https://reviews.apache.org/r/4998/#comment16652>

    Can we add some debugging for this exception?


- Mohammad


On 2012-05-03 20:28:59, Alejandro Abdelnur wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4998/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-05-03 20:28:59)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  adds the option to specify a list of admin groups to check users for admin 
privileges instead of using the adminusers.txt file. the adminusers.txt file 
option is still available if the admin groups list is not specified.
bq.  
bq.  
bq.  This addresses bug OOZIE-773.
bq.      https://issues.apache.org/jira/browse/OOZIE-773
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
1333606 
bq.    
trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 
1333606 
bq.    trunk/docs/src/site/twiki/AG_Install.twiki 1333606 
bq.  
bq.  Diff: https://reviews.apache.org/r/4998/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  run all tests successfully
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alejandro
bq.  
bq.


                
> AuthorizationService should be able to use a group to identify superusers
> -------------------------------------------------------------------------
>
>                 Key: OOZIE-773
>                 URL: https://issues.apache.org/jira/browse/OOZIE-773
>             Project: Oozie
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.2.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 3.2.0
>
>
> Currently the AuthorizationService reads the list of admin users from a file 
> in Oozie's conf. Given than now we have a GroupsService we should have an 
> option do define a list of groups that are considered adminusers. 
> The existing adminusers.txt file would still be supported.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to