----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5063/#review7741 -----------------------------------------------------------
How will a user know what are the system supported versions? There could be a utility for that. Another point, if a user gives a wrong or not supported version, how will that be communicated to the end-user. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/5063/#comment17041> If name is 'null' after that, what will happen? Should we throw an error? - Mohammad On 2012-05-08 07:06:23, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5063/ > ----------------------------------------------------------- > > (Updated 2012-05-08 07:06:23) > > > Review request for oozie. > > > Summary > ------- > > The sharelibrary override is supported at Oozie server level and at workflow > job level. > > The share library name will be resolved using the following precedence order: > > action.sharelib.for.#ACTIONTYPE# in the action configuration (at action level) > action.sharelib.for.#ACTIONTYPE# in the job configuration (at job level) > action.sharelib.for.#ACTIONTYPE# in the oozie server configuration (at oozie > server level) > action's ActionExecutor getDefaultShareLibName() method (default) > > > This addresses bug OOZIE-830. > https://issues.apache.org/jira/browse/OOZIE-830 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 1335346 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 1335346 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1335346 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 1335346 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 1335346 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 1335346 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1335346 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1335346 > trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1335346 > > Diff: https://reviews.apache.org/r/5063/diff > > > Testing > ------- > > besides testcases, tested in a deployed setup > > > Thanks, > > Alejandro > >
