[
https://issues.apache.org/jira/browse/OOZIE-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408163#comment-13408163
]
Alejandro Abdelnur commented on OOZIE-477:
------------------------------------------
Thanks Mona, following feedback on the latest patch.
*FSActionExecutor*
I'm a bit puzzled by this line:
fsConf.set(has.SUPPORTED_FILESYSTEMS,
System.getProperty(has.SUPPORTED_FILESYSTEMS));
All this method should go away and simply do a
Services.get().get(HadoopAcessorService.class).checkSupportFileSystem(URI)
inline.
*HadoopAccessorService.checkSupporteFileSystem()*
Instead expecting a fileScheme, we should expect a URI and check the scheme of
it.
we should not pass a configuration object, instead we should used the oozie
configuration to check for the supported filesystems.
we should load the supported filesystems in a set at init time, not to do this
logic over an over.
there is are return deep in an IF, instead we should set 'isSupported = true'.
The 'if(supportedSchemes != null) should be replaced with an ELSE.
Instead returning true/false and delegating to the caller to fail, the
checkSupportedFileSystem() method should throw a HadoopAccessorException.
> Adding configurable filesystem support instead of hardcoded "hdfs"
> ------------------------------------------------------------------
>
> Key: OOZIE-477
> URL: https://issues.apache.org/jira/browse/OOZIE-477
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Mayank Bansal
> Assignee: Mona Chitnis
> Labels: federation
> Attachments: OOZIE-477v1.patch, OOZIE-477v2.patch
>
>
> This allows for configurable filesystem support in Hadoop 23 and not only
> "hdfs://".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
