[
https://issues.apache.org/jira/browse/OOZIE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413857#comment-13413857
]
Virag Kothari commented on OOZIE-907:
-------------------------------------
Why is this being done?
launcherConf.set(CONF_OOZIE_ACL_VIEW_JOB,
actionConf.get(CONF_OOZIE_ACL_VIEW_JOB));
The value can be null.
I think this line should be removed. The acl property for 'oozie.launcher' is
already set. Same comment for acl modify.
Also, its better to create separate test methods for each of the cases
> Default ACL settings for Oozie launcher
> ---------------------------------------
>
> Key: OOZIE-907
> URL: https://issues.apache.org/jira/browse/OOZIE-907
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk, 3.2.1
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: trunk, 3.2.1
>
> Attachments: OOZIE-907.patch, OOZIE-907v2.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> This is about the oozie settings:
> - oozie.launcher.mapreduce.job.acl-view-job
> - oozie.launcher.mapreduce.job.acl-modify-job
> Currently, these settings default to the most restrictive permissions.
> Instead they should default to the values set by the user
> for the settings:
> - mapreduce.job.acl-view-job => oozie.launcher.mapreduce.job.acl-view-job
> - mapreduce.job.acl-modify-job =>
> oozie.launcher.mapreduce.job.acl-modify-job
> Typically, users will want to set these same values for the mapreduce and
> oozie settings, so its a reasonable default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
