> On July 26, 2012, 2:26 a.m., Mona Chitnis wrote: > > At a couple of places, the update and insert operations were followed by > > queuing up ActionStartX and ActionKillX commands. Will there be a race > > condition beween those queued commands and this BulkUpdate executor?
No. All the queued commands are executed only after the command queuing them executes successfully > On July 26, 2012, 2:26 a.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java, > > line 75 > > <https://reviews.apache.org/r/6090/diff/2/?file=127139#file127139line75> > > > > Can a LinkedHashSet be used instead of ArrayList to maintain the order > > in which entities were added? No need as order is not important. Btw, List does maintain order > On July 26, 2012, 2:26 a.m., Mona Chitnis wrote: > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertJPAExecutor.java, > > line 164 > > <https://reviews.apache.org/r/6090/diff/2/?file=127141#file127141line164> > > > > change word 'actions' to 'jobs' ok..will do..thxs > On July 26, 2012, 2:26 a.m., Mona Chitnis wrote: > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertJPAExecutor.java, > > line 238 > > <https://reviews.apache.org/r/6090/diff/2/?file=127141#file127141line238> > > > > Can the exception message be confirmed by checking for 'rollback' only? can confirm it for 'action does not exist' - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6090/#review9493 ----------------------------------------------------------- On July 23, 2012, 7:25 a.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6090/ > ----------------------------------------------------------- > > (Updated July 23, 2012, 7:25 a.m.) > > > Review request for oozie. > > > Description > ------- > > Workflow action status 'Ok' but the workflow job remains in 'RUNNING' > > > This addresses bug oozie-903. > https://issues.apache.org/jira/browse/oozie-903 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1364521 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkUpdateInsertJPAExecutor.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBulkUpdateInsertJPAExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/6090/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Virag Kothari > >
