[
https://issues.apache.org/jira/browse/OOZIE-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427456#comment-13427456
]
Alejandro Abdelnur commented on OOZIE-913:
------------------------------------------
patch looks good, a comments though:
*FSActionExecutor: patch introduces unused imports
*FSActionExecutor, resolveToFullPath(): when the path is absolute, we should
use the namenode scheme&authority to create the path, not the full namenode
path (in case somebody specifies as their name-node hdfs://foo:1000/bar).
*FSActionExecutor, resolveToFullPath(): If I'm not mistaken, pathScheme +
pathAuthority will produce 'hdfsHOST:PORT', not 'hdsf://HOST:PORT. Same as
previous comment on the namenode path
*FSActionExecutor, parseJobXML() & parseConfiguration(): are this methods
duplicated from other place? I believe so. Shouldn't they belong to
JavaActionExecutor and everybody consume it from there?
> Add Name Node, job-xml, and configuration Elements to FS action
> ---------------------------------------------------------------
>
> Key: OOZIE-913
> URL: https://issues.apache.org/jira/browse/OOZIE-913
> Project: Oozie
> Issue Type: Improvement
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Attachments: OOZIE-913-v2.patch, OOZIE-913.patch
>
>
> Adding a name node Element to the FS action will allow users to shorten FS
> actions and avoid specifying the name node (hdfs://HOST:PORT) multiple times.
> We can also add job-xml and configuration elements to allow users to set
> properties when the FS instance is created.
> e.g.
> {code}
> <action name="fs-node">
> <fs>
> <name-node>hdfs://host:port</name-node>
> <job-xml>fs-info.xml</job-xml>
> <configuration>
> <property>
> <name>some.property</name>
> <value>some.value</value>
> </property>
> </configuration>
> <mkdir path="/user/${wf:user()}/output-data/1"/>
> <mkdir path="/user/${wf:user()}/output-data/2"/>
> </fs>
> <ok to="end"/>
> <error to="fail"/>
> </action>
> {code}
> This can then also leverage the global section from OOZIE-874 automatically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
