[
https://issues.apache.org/jira/browse/OOZIE-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427708#comment-13427708
]
Alejandro Abdelnur commented on OOZIE-239:
------------------------------------------
Robert, the patch looks good, still a few things I'd change:
* rename ParameterHandler to ParameterVerifier
* the ParameterHandler bails out if jobConf is null, jobConf cannot be null,
you should use ParamCheck.notEmpty() to enforce that
* the ParameterHandler logic fails on the first missing parameter, this will
lead to multiple failed attempts until I got things right. How about collecting
all the missing parameters and then reporting ALL of them in the exception?
> Add formal parameters to WF & COORD XML
> ---------------------------------------
>
> Key: OOZIE-239
> URL: https://issues.apache.org/jira/browse/OOZIE-239
> Project: Oozie
> Issue Type: Improvement
> Reporter: Hadoop QA
> Assignee: Robert Kanter
> Attachments: OOZIE-239.patch
>
>
> Formal parameters definition with inline default values
> Enforcing formal parameters a comprehensive error checking can be done at
> submission time for EL expressions through out the workflow XML.
> For example:
> <code>
> <workflow-app>
> <parameters>
> <!-- with no default value -->
> <property>
> <name>input</name>
> </property>
> <!-- with default value -->
> <property>
> <name>output</name>
> <value>${input}.out</name>
> </property>
> ...
> </parameters>
> ...
> </workflow-app>
> </code>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
