----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6073/#review10058 -----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/6073/#comment21291> remove the comment if not required trunk/core/src/main/java/org/apache/oozie/BundleEngine.java <https://reviews.apache.org/r/6073/#comment21292> shoudn't this be '!=2' trunk/core/src/main/java/org/apache/oozie/BundleEngine.java <https://reviews.apache.org/r/6073/#comment21293> value can be an empty string. e.g when coordinators=' ' this should be handled here so a query with empty values are not run against db trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/6073/#comment21288> as only querying through bundle name is allowed, should this option be change to bundlename=<B>? Also, we should specify here that bundle name is required while others are optional trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/6073/#comment21289> typo values trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/6073/#comment21290> why is this changed? trunk/core/src/main/java/org/apache/oozie/BundleEngine.java <https://reviews.apache.org/r/6073/#comment21294> isn't the level checking redundant? trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java <https://reviews.apache.org/r/6073/#comment21296> is this required now as the check seems to be done in bundle engine. trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java <https://reviews.apache.org/r/6073/#comment21297> should be jpaexception trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java <https://reviews.apache.org/r/6073/#comment21298> should be jpaexception trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java <https://reviews.apache.org/r/6073/#comment21299> can response be null? trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java <https://reviews.apache.org/r/6073/#comment21300> this string seems too long and difficult to read. can q.toString() be assigned to variable as it is used at multiple places trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java <https://reviews.apache.org/r/6073/#comment21301> what is the need for retrieving total number of values? trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java <https://reviews.apache.org/r/6073/#comment21302> using SQL IN clause is better than OR trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java <https://reviews.apache.org/r/6073/#comment21304> JPAException trunk/core/src/test/java/org/apache/oozie/TestBulkRequest.java <https://reviews.apache.org/r/6073/#comment21305> seems like the web services test and jpaexecutor tests are mixed. The Web services test should be in oozie.servlet package while the jpa executor tests should be in executor.jpa trunk/core/src/test/java/org/apache/oozie/TestBulkRequest.java <https://reviews.apache.org/r/6073/#comment21306> Xdatatestcase has method like addRecordTo*Table..its better to make use of them directly trunk/core/src/test/java/org/apache/oozie/TestBulkRequest.java <https://reviews.apache.org/r/6073/#comment21307> I think oozie follows underscore convention only for private unit test cases. trunk/core/src/test/java/org/apache/oozie/TestBulkRequest.java <https://reviews.apache.org/r/6073/#comment21308> some test cases can be added 1) For multiple coordinators, 2) default values of status 3) multiple bundle ids for a name 4) when no results are returned trunk/docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/6073/#comment21309> it should be offset instead of start - Virag Kothari On Aug. 8, 2012, 9:03 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6073/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 9:03 p.m.) > > > Review request for oozie. > > > Description > ------- > > First draft of the implementation of Bulk Monitoring API - RESTful WS API to > traverse through bulk of multiple Oozie job levels and find the > actions/workflows based on multiple filtering criteria > > This is WIP > - refining API > - testing to see results > > Uploading the patch to give a flavor of the implementation following design > reviews > > > This addresses bug OOZIE-848. > https://issues.apache.org/jira/browse/OOZIE-848 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1370965 > trunk/client/src/main/java/org/apache/oozie/client/BulkResponseJob.java > PRE-CREATION > trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1370965 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > 1370965 > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java > 1370965 > trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1370965 > trunk/core/src/main/java/org/apache/oozie/BulkResponseInfo.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1370965 > trunk/core/src/main/java/org/apache/oozie/client/rest/BulkResponse.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java > 1370965 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java > 1370965 > trunk/core/src/test/java/org/apache/oozie/TestBulkRequest.java PRE-CREATION > trunk/docs/src/site/twiki/WebServicesAPI.twiki 1370965 > > Diff: https://reviews.apache.org/r/6073/diff/ > > > Testing > ------- > > not yet > > > Thanks, > > Mona Chitnis > >
