Mona,

Latest patch in RB seems old. I had the latest copy from JIRA before
JIRA went down

Thx.

---------
HadoopAccessorService:

* SUPPORTED_FILESYSTEMS property should be 'CONF_PREFIX +
"supported.filesystems"'

* we should do String[] schemesFromConf =
conf.getStrings(SUPPORTED_FILESYSTEMS, new String[]{"hdfs"});

* supportedSchemes instance variable should be private.

* checkSupportedFileSystem() does not need to use a synchronized block

LauncherMapper:

* lines 502 seem wrong, pathNew is an HDFS location:

Path pathNew = new Path(new Path(outputData.toString()), new
Path(actionDir, ACTION_OUTPUT_PROPS));

seems it should not change, just the FS instance next should be
obtained from actionDir path.

we have to make sure the URI contains the right protocol://authority

* line 533: same as comment for line 503.

* line 603: same as comment for line 503.

* line 616: same as comment for line 503.

* line 533: same as comment for line 503.

* line 626: same as comment for line 503. this particular one seems OK
but it should be verified please.

oozie-default.xml:

* property name should be change as suggested in the
HadoopAccessorService comments

WorkflowAppService

* line 169, there is a Path constructor that takes an URI
* line 260, no need to trim a filename from FileStatus
---------

-- 
Alejandro

Reply via email to