----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6560/#review10234 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java <https://reviews.apache.org/r/6560/#comment21672> the regex should have start anchor (^) too, otherwise will match JUNKGMT-0530 as valid timezone. Tested with ^UTC|^GMT(\\+|\\-)\\d{4}$ and works We can have test case for this too trunk/core/src/main/java/org/apache/oozie/util/ParamChecker.java <https://reviews.apache.org/r/6560/#comment21674> In addition, javadoc needs to be updated. Also, there are some other places like CoordElFunctions where UTC is used in javadoc. Probably they need to be updated too. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java <https://reviews.apache.org/r/6560/#comment21668> Tabs trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java <https://reviews.apache.org/r/6560/#comment21669> tabs trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommandNonUTC.java <https://reviews.apache.org/r/6560/#comment21670> tabs - Virag Kothari On Aug. 13, 2012, 4:22 p.m., Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6560/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2012, 4:22 p.m.) > > > Review request for oozie. > > > Description > ------- > > Current Oozie coordinator expects and resolves dates in UTC (ie > 2009-08-10T00:00Z). UTC datetimes are used for start/end/pause of jobs, > datasets initial-instance and to resolve dataset instance URI templates. > Adding support for a non UTC timezone it would enable deployments where they > use a timezone different than UTC as standard. This seems quite common in > countries where they don't observe DST changes. > > The patch adds an Oozie configuration property 'processing.timezone', that > could be set to a GMT(+/-)#### offset timezone. Note that a GMT offset > timezone does not support DST. > In addition, to reduce users/admins possibility of mistakes because the non > UTC timezone, if the processing time is set to a value other than UTC, all > datetime parameters in the coordinator applications and job parameters must > be expressed with the corresponding GMT offset. For example, if the > processing timezone is set to GMT+0530, a valid datetime would be > 2009-08-10T05:30+0530. > > The patch seems bigger than it is because a couple of DateUtils methods that > had UTC in their names have been renamed and all its uses through out the > code are now diffs in the patch. > > > This addresses bug OOZIE-948. > https://issues.apache.org/jira/browse/OOZIE-948 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1372494 > trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1372494 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java > 1372494 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java > 1372494 > > trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > 1372494 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java > 1372494 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > 1372494 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1372494 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/coord/CoordELEvaluator.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1372494 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/service/Services.java 1372494 > trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1372494 > trunk/core/src/main/java/org/apache/oozie/util/ELConstantsFunctions.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/util/ParamChecker.java 1372494 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java > 1372494 > trunk/core/src/main/java/org/apache/oozie/util/db/SLADbXOperations.java > 1372494 > trunk/core/src/main/resources/oozie-default.xml 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommandNonUTC.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java > 1372494 > trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java > 1372494 > trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java > 1372494 > trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInfoJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForInputCheckJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionIdsForDatesJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java > 1372494 > trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java > 1372494 > trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java > 1372494 > > trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 1372494 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1372494 > > trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java > 1372494 > trunk/core/src/test/java/org/apache/oozie/util/TestDateUtils.java > PRE-CREATION > trunk/core/src/test/resources/coord-action-for-action-input-check.xml > 1372494 > trunk/docs/src/site/twiki/AG_Install.twiki 1372494 > trunk/docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 1372494 > > Diff: https://reviews.apache.org/r/6560/diff/ > > > Testing > ------- > > run all testcases successfully, also there is a new testcase that tests > coordinator using an alternate processing timezone. > > > Thanks, > > Alejandro Abdelnur > >
