Timothy Normand Miller:
>I have two notes for you.
>
>One is that you don't have any in-coming data connected to write_data.
> Instead, you've connected that to the same signal as read_data.  But
>you probably knew that.  :)

Aaah.. This was of course a test to see how thoroughly you guys read my
code :) Fixed in the current version

>
>Also, we didn't document the interface for SPI so well, so I need to
>explain a little.  read_cmd, read_dummy_byte (which is itself just a
>flag), and write_cmd are all configuration options.  They're static
>values that'll be set externally, so they wouldn't to through the
>fifo; they'd just appear on the interface of the module.

Ok, I made the read/write cmd and the read_dummy_byte skip the FIFO, and
go directly into the spi_controller. Furthermore, since they're static
values, I also separated the two in two different inputs. 

I also committed a clean-up where I removed some of the FIFO/SPI code
from the toplevel, and started mapping up the signals from the different
SPI wrappers. To somewhat finish this would be the logical next step :)


Merry Christmas and a happy new year to you all :)


-- 
Life on the earth might be expensive, but it 
includes an annual free trip around the sun.

Kenneth Østby
http://langly.org
_______________________________________________
Open-graphics mailing list
[email protected]
http://lists.duskglow.com/mailman/listinfo/open-graphics
List service provided by Duskglow Consulting, LLC (www.duskglow.com)

Reply via email to