Also, there are updates to the tools that Howard has made that need to be merged. Also, I myself prefer modularity. Perhaps a compromise with Howard's needs would be to ensure that everything stays within one directory.
On Tue, Nov 4, 2008 at 7:31 AM, howard parkin <[EMAIL PROTECTED]> wrote: > A goal I had in writing each diagnostic test was > to try and keep all the functionality required for each > test locally in the same file. I've lost count of the number > of times I've had to go looking for some piece of > functionality in some other directory that's buried in > an include of an include etc that is somewhere > else in the tree. Your changes are not of that nature, > but personally I prefer how it was with the local oga_map > function. But whatever. > > On Mon, Nov 3, 2008 at 3:48 PM, Petter Urkedal <[EMAIL PROTECTED]> wrote: >> A have a fix for an mmap return value check to the C files under >> tools/oga1_diag, but instead of fixing each file, I moved the common >> parts into a separate file and made some bigger changes. Also, I >> rewrote the Makefile to use an installed pciutils. Since it's a bit >> invasive, you may want to look at the changes before I commit: >> >> >> http://git.eideticdew.org/cgit/ogp-pu/commit/?id=636fb225b2d96df503d737359ebcab13090e27cc >> >> Also the files were in DOS format. May I strip off the CRs? >> _______________________________________________ >> Open-graphics mailing list >> [email protected] >> http://lists.duskglow.com/mailman/listinfo/open-graphics >> List service provided by Duskglow Consulting, LLC (www.duskglow.com) >> > _______________________________________________ > Open-graphics mailing list > [email protected] > http://lists.duskglow.com/mailman/listinfo/open-graphics > List service provided by Duskglow Consulting, LLC (www.duskglow.com) > -- Timothy Normand Miller http://www.cse.ohio-state.edu/~millerti Open Graphics Project _______________________________________________ Open-graphics mailing list [email protected] http://lists.duskglow.com/mailman/listinfo/open-graphics List service provided by Duskglow Consulting, LLC (www.duskglow.com)
