Quoting Bill Erickson <[EMAIL PROTECTED]>:

This patch introduces a new configuration stanza, <options> in the
implementation_config of an institution in oils_sip.xml. Currently,
the only option is 'msg64_summary_datatype', which can have a value of
'barcode', which causes message 64 responses to return item barcodes
instead of item titles, the previously default behaviour in
Evergreen's SIP2 implementation. Setting any value other than
'barcode', or not setting this value at all will result in message 64
returning titles.

+               if($return_datatype[0]->{value} ne 'title') {
+                       push( @o, __circ_to_barcode($self->{editor}, $circid));
+               } else {
+                       push( @o, __circ_to_title($self->{editor}, $circid));
+               }

In this case, if the option is not set, then it will return a barcode.  How
about we change that first test to:

if($return_datatype[0]->{value} eq 'barcode') { ...


I guess I'm editorializing that barcode should be the default return value if the option is unset. :)

Seriously? Oops. I have no problem with your suggested adjustment.

~B

Reply via email to