Thanks Yamil, I accidentally added a few more commits to that pull request… I’m still learning about git, and using branches to separate things. Please ignore those for now, I want to submit those separately. The ones that have to do with the offline.properties and adding the tab name for the address alerts feature.
Josh From: [email protected] [mailto:[email protected]] On Behalf Of Yamil Suarez Sent: Friday, September 05, 2014 4:57 PM To: Documentation discussion for Evergreen software Subject: Re: [OPEN-ILS-DOCUMENTATION] Pull request - Address Alert feature + plus a few other Josh, I looked over most of your commits already, and it all looked great. I did not get to processing your pull request this week, but I will work on it early next week. I will probably do each commit individually and review as I go. I may edit the "subject" of each commit a bit, for example by adding a prefix that says "Docs:" like we talk about earlier. That is an almost unspoken practice that we need to write down somewhere :) Thanks for all your contributions, Yamil On Tue, Sep 2, 2014 at 5:28 PM, Josh Stompro <[email protected]<mailto:[email protected]>> wrote: Hello, I just created a github pull request to include the documentation changes I’ve been working on. Please take a look at it and let me know if there are any suggestions. https://github.com/evergreen-library-system/Evergreen/pull/15 Thank you to Yamil for helping me out with all the tips and with asciidoc formatting. Josh _______________________________________________ OPEN-ILS-DOCUMENTATION mailing list [email protected]<mailto:[email protected]> http://list.georgialibraries.org/mailman/listinfo/open-ils-documentation -- -------------------------------- Yamil Suarez, MCS Library System Administrator/Developer Stan Getz Library Berklee College of Music 1140 Boylston St Boston, MA 02215 [email protected]<mailto:[email protected]> 617-747-2617
_______________________________________________ OPEN-ILS-DOCUMENTATION mailing list [email protected] http://list.georgialibraries.org/mailman/listinfo/open-ils-documentation
