Hi, On Sat, Sep 6, 2014 at 1:32 PM, Josh Stompro <[email protected]> wrote: > Thanks for all the tips and info everyone. Please take a look at what I’ve > come up with for documenting the zip code pre-fill feature and let me know > what you think. https://gist.github.com/stompro/5d6bea620f7cc01b8443
Overall, looks good, and I appreciate how thorough it is. I have a few nits to pick... [1] "ZIP", not "zip" or "Zip", as it's an acronym. [2] It's not necessary to restart Evergreen, just specific services. Specifically, just "opensrf.setting" and "open-ils.search" when uncommenting <zips_file>, or just "open-ils.search" if modifying a zips_file that's already in use. However: for the moment a plain "restart Evergreen" is fine, as providing details of how to restart individual services is worth it's own section in the manual. > I didn’t add info about using the google API to brute force gather the data, > it seems like an overly complex solution compared with the others. I also > didn’t add info about using geocoder.ca to gather Canadian postal codes > since the site doesn’t load for me. +1 > I would also like to propose that the comments in zips.pm be updated to > reflect the fact that the areacode is not used by register.js, maybe it was > in the past, but not right now. That's reasonable; feel free to submit a patch. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: [email protected] direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ OPEN-ILS-DOCUMENTATION mailing list [email protected] http://list.georgialibraries.org/mailman/listinfo/open-ils-documentation
