Mike Christie wrote:

> Erez Zilber wrote:
>   
>>> Fix indentation and remove trailing spaces.
>>>
>>> Signed-off-by: Erez Zilber [EMAIL PROTECTED]
>>>       
>>  
>>
>> Mike? Are you ok with this patch?
>>
>>     
>
> It is already broken. Did you run a script for this? Could you send the 
> script? Then when I merge Eli's patch I can just run the script and you 
> do not have to worry about the breakage?
>
> The kernel modules in the open-iscsi.git tree are also different from 
> upstream and the bnx2i tree, so a script that I can run against them 
> would make it easier for use to sync up, unless you want to send patches 
> for those messes.
>   
I have a script that finds indentation problems (attached). It doesn't
fix them, but that should be really easy to do.

Erez

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

#!/usr/bin/env perl
# print messages for misformatted C code
# usage: ws.pl <filenames>

while (<>) {
  chomp;
  if (/\s$/) {
    print $ARGV, "(", $., "): trailing whitespace <", $_, ">\n";
  }
  if (/^\s*     /) {
    print $ARGV, "(", $., "): space followed by tab <", $_, ">\n";
  }
  if (/^        /) {
    print $ARGV, "(", $., "): 8 spaces for indent <", $_, ">\n";
  }
}  continue {
  close ARGV if eof;
}

Reply via email to