Erez Zilber wrote:
> On Tue, Jul 15, 2008 at 3:42 AM, Mike Christie <[EMAIL PROTECTED]> wrote:
>> Erez Zilber wrote:
>>> On Wed, Jul 9, 2008 at 11:22 AM, Erez Zilber <[EMAIL PROTECTED]> wrote:
>>>> RHEL 5.2 is based on kernel version 2.6.18, but contains code
>>>> that wasn't included in 2.6.18 vanilla. The kernel Makefile uses
>>>> 2.6.14-19_compat.patch for it, and this creates compilation errors
>>>> of symbol redefinition. We should have a separate compat patch for
>>>> RHEL 5.2.
>>>> Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
>>> Mike,
>>> Any news about this patch?
>> Sorry for the delay.
>> I was trying to make it more generic, because we have similar issues on
>> SUSE and we have similar issues on multiple RHEL5 kernels.
> OK - what do you suggest?

I do not know. At least can we add ifdefs in the existing patches to 
detect distro kernels? Can you do

ifdef kernel version >= 2.6.18-92

so we at least do not need to have multiple distro patches?

>> I also think you might have sent the wrong patch, or I was not sure what
>>  you were trying to fix.
>> The problem I hit with distro kernels like RHEL are the following:
>> 1. Redefinition of is_power_of_2
>> 2. Redefinition of shost_priv
>> 3. Redefintion of scsi_set_resid
> Note that 2.6.18-92.el5_compat.patch (maybe deserves a better name) is
> very similar to 2.6.14-19 except for some functions that I removed
> (e.g. is_power_of_2). The kernel Makefile patch uses this compat patch
> for RHEL 5.2, so the redefinition problem is solved.

Ah, yeah you are right. I messed up and used something slightly off 
2.6.18-92, so it did not get patched right.

You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at

Reply via email to