Andrew Morton wrote: >> + unsigned long octet; >> + const char *parse = buf; >> + char *endp; >> + int i; >> + >> + for (i = 1; i <= 4; i++) { >> + octet = simple_strtoul(parse, &endp, 10); >> + if (endp == buf || octet > 255 || >> + (i < 4 && *endp != '.') || >> + (i == 4 && *endp != '\0' && *endp != '\n')) >> + return -EINVAL; >> + a = (a << 8) | octet; >> + parse = endp+1; >> + } >> + pi->iscsi_ipaddr = htonl(a); >> + return endp-buf; >> +} >> > > This appears to be taking a dotted quad ipv4 address in ascii form, > turning it into a u32 while performing checking? > > Surely we have a library function somewhere in networking which does > this? If not, I'd suggest writing one. > >
try in_aton() from include/linux/inet.h. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/open-iscsi -~----------~----~----~----~------~----~------~--~---