Hi Mike,

Mike Christie wrote:
> Erez Zilber wrote:
>> On Mon, Aug 4, 2008 at 7:30 PM, Mike Christie <[EMAIL PROTECTED]> 
>> wrote:
>>> Erez Zilber wrote:
>>>> On Wed, Jul 16, 2008 at 8:26 PM, Mike Christie 
>>>> <[EMAIL PROTECTED]> wrote:
>>>>> Erez Zilber wrote:
>>>>>> On Tue, Jul 15, 2008 at 3:42 AM, Mike Christie 
>>>>>> <[EMAIL PROTECTED]> wrote:
>>>>>>> Erez Zilber wrote:
>>>>>>>> On Wed, Jul 9, 2008 at 11:22 AM, Erez Zilber 
>>>>>>>> <[EMAIL PROTECTED]> wrote:
>>>>>>>>> RHEL 5.2 is based on kernel version 2.6.18, but contains code
>>>>>>>>> that wasn't included in 2.6.18 vanilla. The kernel Makefile uses
>>>>>>>>> 2.6.14-19_compat.patch for it, and this creates compilation errors
>>>>>>>>> of symbol redefinition. We should have a separate compat patch for
>>>>>>>>> RHEL 5.2.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Erez Zilber <[EMAIL PROTECTED]>
>>>>>>>>>
>>>>>>>> Mike,
>>>>>>>>
>>>>>>>> Any news about this patch?
>>>>>>>>
>>>>>>> Sorry for the delay.
>>>>>>>
>>>>>>> I was trying to make it more generic, because we have similar 
>>>>>>> issues on
>>>>>>> SUSE and we have similar issues on multiple RHEL5 kernels.
>>>>>> OK - what do you suggest?
>>>>> I do not know. At least can we add ifdefs in the existing patches to
>>>>> detect distro kernels? Can you do
>>>>>
>>>>> ifdef kernel version >= 2.6.18-92
>>>>>
>>>>> so we at least do not need to have multiple distro patches?
>>>> Sorry for the long delay. I've attached a new patch that doesn't add a
>>> No prbolem. Thanks for doing this.
>>>
>>>> new compat patch. I have only CentOS 5.2, so I wasn't able to test it
>>>> on other kernels. On CentOS 5.2 it looks fine.
>>>>
>>> Thanks a lot. I am testing it now on the kernels.
>>
>> Mike,
>>
>> Any news about that?
>>
> 
> 
> I was waiting for Hannes. Hannes, is the only problem with the compat 
> patches on SLES the scsi cmnd or scatterlist helpers?
> 
Various bits and pieces. For SLES10 SP2 I've updated the SCSI stack
to 2.6.22, so while the kernel version is still 2.6.16 the SCSI
midlayer is actually 2.6.22, hence the backport.

> Is there a way I can just add ifdefs to check for SLES kernels? Which 
> ones are they?
> 
Sure:

We have CONFIG_SLE_VERSION and CONFIG_SLE_SP. So you should test for
CONFIG_SLE_VERSION == 10 && CONFIG_SLE_SP >= 2.

Cheers,

Hannes




--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

Reply via email to