Karen Xie wrote:
> [PATCH 2.6.29-rc] iscsi - add offset and count to alloc_pdu().
> 
> From: Karen Xie <k...@chelsio.com>
> 
> Hi, Mike,
> 
> I looked through libiscsi.c, libiscsi_tcp.c and iscsi_tcp.c. It does seem to 
> be a little messy to merge the two functions. Especially the BHS is 
> constructed after pdu_alloc(), and iscsi_tcp uses the BHS fields in 
> init_pdu(). 
> 
> So I only added the offset and count as additional parameters to alloc_pdu(). 
> So that the pdu payload is known at the time of pdu memory allocation.
> 

Ehhhhhh, yeah it is workable. Give me a day to check this out more. It 
makes the api akward because we get the data offset and len, but not the 
header. Let me see if I can build on your patch.

Thanks.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

Reply via email to