drop lkml.

Scott James Remnant wrote:
> The scsi_transport_iscsi module is missing the net-pf-16-proto-8 alias
> that would cause it to be auto-loaded when a socket of that type is
> opened.  This patch adds the alias.
> 
> Signed-off-by: Scott James Remnant <sc...@canonical.com>
> Signed-off-by: Tim Gardner <tim.gard...@canonical.com>
> ---
>  drivers/scsi/scsi_transport_iscsi.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_transport_iscsi.c 
> b/drivers/scsi/scsi_transport_iscsi.c
> index 75c9297..056fdae 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -22,6 +22,8 @@
>   */
>  #include <linux/module.h>
>  #include <linux/mutex.h>
> +#include <linux/net.h>
> +#include <linux/netlink.h>
>  #include <net/tcp.h>
>  #include <scsi/scsi.h>
>  #include <scsi/scsi_host.h>
> @@ -2013,3 +2015,4 @@ MODULE_AUTHOR("Mike Christie <micha...@cs.wisc.edu>, "
>  MODULE_DESCRIPTION("iSCSI Transport Interface");
>  MODULE_LICENSE("GPL");
>  MODULE_VERSION(ISCSI_TRANSPORT_VERSION);
> +MODULE_ALIAS_NET_PF_PROTO(PF_NETLINK, NETLINK_ISCSI);

Sorry, I missed this until today.

How are you guys using this, or how is this useful? It will load the 
transport class, but the lower level drivers like iscsi_tcp or ib_iser 
will not be loaded so you cannot do anything with it. Did you send some 
other patches to autoload the lld modules?

I thought it would be useful for the iscsid transport class check. 
However, I think iscsid currently checks for the sysfs version before 
starting the netlink socket so the transport class version check is 
missed. Did you send a patch to rearrange that?

If you guys are sending them to the iscsi list only they might be stuck 
in the spam filtering. Let me know if you have. I will check.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

Reply via email to