On 06/07/2009 03:40 AM, Erez Zilber wrote: > On Thu, Jun 4, 2009 at 7:59 PM, Mike Christie<micha...@cs.wisc.edu> wrote: >> Erez Zilber wrote: >>>> With that patch you can do both. module_params are exposed in sysfs and >>>> if you set IWUSR then you can write to it. >>>> >>>> echo 1> /sys/module/libiscsi/debug_libiscsi >>>> >>>> to turn on >>>> >>>> echo 0> /sys/module/libiscsi/debug_libiscsi >>>> >>>> to turn off. >>> OK, thanks. >>> >>>>> We can have separate logging for stuff like login, scsi, error >>>>> handling, connection state etc. >>>>> >>>> Send a patch. Note that right now each module has its own logging param. >>>> So the higher level libiscsi stuff has one. The common iscsi over tcp >>>> module libiscsi_tcp has one, then iscsi_tcp has its own. You may want to >>>> merge them all into one or make it so you can turn it on/off at each >>>> layer/level. >>> I've attached a patch that add 2 more module parameters to libiscsi, >>> so now we have conn, session& eh events. Later, we can add more >>> logging events. If you're ok with this fix, I will send another patch >> Looks ok to me. >> >>> that fixes the broken compat patches. BTW - which compat patches are >> Ok thanks. >> >>> still maintained? >>> >> 2.6.14-23_compat.patch >> 2.6.24_compat.patch >> 2.6.26_compat.patch >> 2.6.27_compat.patch >> > > Attached with fixes to compat patches. >
Thanks for also fixing the up the compat patches. Merged in 2cda98cea0939da83627c5a5818063ed3c90fbe7. I am also going to send it out now for 2.6.31. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~----------~----~----~----~------~----~------~--~---
