On Sat, 2009-06-13 at 14:29 -0700, k...@chelsio.com wrote:
> [PATCH 1/2 2.6.30-rc] cxgb3i -- add a refcnt to track ddp usage
>
> From: Karen Xie <k...@chelsio.com>
>
> The iscsi ddp functionality could be used by multiple iscsi entities,
> add a refcnt to keep track of it, so we would not release it pre-maturely.
The code is fine as it stands but, I wonder, would you consider using a
kref for this? The reasons are twofold:
1. It's a well understood kernel paradigm that works ... this would
be helpful for the far distant time when chelsio no longer wants
to maintain this driver.
2. It includes useful and appropriate warnings for common bugs in
refcounted code, such as use of a freed reference.
James
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---
