Mike Christie wrote:
> Anil Veerabhadrappa wrote:
> > diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> > index f741219..98148f3 100644
> > --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> > +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> > @@ -1653,15 +1653,18 @@ static struct iscsi_endpoint
> *bnx2i_ep_connect(struct Scsi_Host *shost,
> >     struct iscsi_endpoint *ep;
> >     int rc = 0;
> >
> > -   if (shost)
> > +   if (shost) {
> >             /* driver is given scsi host to work with */
> >             hba = iscsi_host_priv(shost);
> > -   else
> > +           /* Register the device with cnic if not already
> done so */
> > +           bnx2i_register_device(hba);
> > +   } else
> >             /*
> >              * check if the given destination can be reached through
> >              * a iscsi capable NetXtreme2 device
> >              */
> >             hba = bnx2i_check_route(dst_addr);
> > +
> >     if (!hba) {
> >             rc = -ENOMEM;
> >             goto check_busy;
>
> Do you want to do the test_bit(BNX2I_CNIC_REGISTERED,
> &hba->reg_with_cnic) test here instead of down below. If it
> failed then
> you might try to do a cm_create on a cnic that is not
> properly registered.
>

Good idea.  cm_create() will properly be ok because there is no
hardware interaction.  bnx2i_send_conn_ofld_req() will fail if
the cnic is not properly registered because there will be no call
backs from the hardware events.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

Reply via email to