Hi all,

why do we have this call to iscsi_session_chkready() in queuecommand?

        reason = iscsi_session_chkready(cls_session);
        if (reason) {
                sc->result = reason;
                goto fault;

        if (session->state != ISCSI_STATE_LOGGED_IN) {
                 * to handle the race between when we set the recovery state
                 * and block the session we requeue here (commands could

Seeing that iscsi_session_chkready() returns '0' when 
session->state == ISCSI_STATE_LOGGED_IN _only_,
one of the two is rather pointless.
But as the latter check is far more elaborate than
the iscsi_session_chkready(), I'd advocate for just removing it.



Dr. Hannes Reinecke                   zSeries & Storage
h...@suse.de                          +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
For more options, visit this group at http://groups.google.com/group/open-iscsi

Reply via email to