+static int st_disc_filter(const struct dirent *dir)
+{
+       return strcmp(dir->d_name, ".") && strcmp(dir->d_name, "..") &&
+               strcmp(dir->d_name, ST_CONFIG_NAME);
+}

I'd change the ordering of the compares to improve performance, putting 
strcmp(dir->d_name, ST_CONFIG_NAME) first. My preference of style would also 
add a 
" != 0", but that's my taste.

Ulrich


On 30 Jul 2009 at 21:07, [email protected] wrote:

> Signed-off-by: Shyam Iyer <[email protected]>
> 
> Adds support to autologin to isns discovered target portals.
> 
> > 
> 



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

Reply via email to