Mike Christie wrote:
> On 10/02/2009 02:33 AM, Hannes Reinecke wrote:
>> I would go with this option for a start. We really should aim for
>> making iscsiadm to be as flexible as possible, up to the point where
>> iscsid.conf really just sets some sensible defaults; everything else
>> should be tweaked via calls to iscsiadm.
>>
>> And I doubt the change in the default behaviour is really noticeable;
>> any user seriously using CHAP with different values will benefit from
>> this.
>>
>> Patch is actually quite simple :-)
>>
>> --- a/usr/iscsiadm.c
>> +++ b/usr/iscsiadm.c
>> @@ -2211,12 +2211,12 @@ main(int argc, char **argv)
>>                                  rc = -1;
>>                                  goto out;
>>                          }
>> -
>> -                       memset(&drec, 0, sizeof(discovery_rec_t));
> 
> The patch does not apply. Upstream does not have this memset. The 
> attached which should fix that and also changes the docs to relfect that 
> passing op=update during discovery would update the node records and the 
> discovery one. With your patch it will only update the node records.
> 
Yes, your patch looks better than mine.
As usual :-)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                   zSeries & Storage
h...@suse.de                          +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

Reply via email to