Oren wrote:
> Hello,
> 
> I've encountered too many cases of people thinking the iscsi-iname
> command, just like ifconfig, displays the currently configured IQN,
> not being aware that, in fact, it generates a new IQN.
> The man page (Debian-supplied, not in open-iscsi git) describes it
> best, but the --help string is absolutely misleading or even wrong.
> 
> Here's my patch, that changes the wording to something similar to the
> Debian's man page:
> diff --git a/utils/iscsi-iname.c b/utils/iscsi-iname.c
> index 7cf0e7a..80fc1d1 100644
> --- a/utils/iscsi-iname.c
> +++ b/utils/iscsi-iname.c
> @@ -62,7 +62,7 @@ main(int argc, char *argv[])
>                 prefix = argv[1];
>                 if (( strcmp(prefix, "-h") == 0 ) ||
>                     ( strcmp(prefix, "--help") == 0 )) {
> -                       printf("\nDisplays the iSCSI initiator name
> \n");
> +                       printf("\nGenerates a unique iSCSI node name
> on every invocation\n"
>                         exit(0);
>                 } else if ( strcmp(prefix, "-p") == 0 ) {
>                         prefix = argv[2];
> 

Thanks. Merged in commit 4136ee677385a667de70fdff223c67d4e16842fc.

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~----------~----~----~----~------~----~------~--~---

Reply via email to