On getopt: I always prefer to list options in an ordered way (alphabetically).
- while ((ch = getopt_long(argc, argv, "i:t:g:a:p:d:u:w:U:W:bfvh", + while ((ch = getopt_long(argc, argv, "i:t:g:a:p:d:u:w:U:W:bnfvh", On 7 Jan 2010 at 14:16, Alex Zeffertt wrote: > Mike Christie wrote: > > > > Thanks for doing this. Sorry for the late reply. > > > > > > Just one comment on the patch. Could you move the code in the 'n' case > > > > + case 'n': > > + /* > > + * Bring up NICs required by targets in iBFT > > + * using IP addresses and routing info from iBFT. > > + */ > > > > ...... > > > > > > to some helper function, so it is not so crowed and a little easier to read? > > > > No problem. Please find a new patch attached. > > Regards, > > Alex >
-- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.