Eddie/Ben, Sounds like a good idea to me. Our current solution needs net_ifacename, ipaddress, hwaddress & transport_name to work. This would require iface.vlan inplace of iface.net_ifacename + iface.hwaddress, right ? -Anish
> -----Original Message----- > From: Benjamin Li [mailto:be...@broadcom.com] > Sent: Wednesday, November 03, 2010 1:05 PM > To: Mike Christie > Cc: firstname.lastname@example.org; Anish Bhatt; Eddie Wai > Subject: Re: case sensitivity of hardware addresses & vlan configs > > Hi Anish, > > For the current the Broadcom solution using VLAN's, we currently have > the use the standard Linux tool, vconfig to create a VLAN interface. > This doesn't give much flexability, so we are working on a solution to > utlize the existing "iface.subnet_mask" and "iface.vlan" fields so that > users can specify multiple VLAN's configurations via multiple ifaces > files. This way the iSCSI offload solution doesn't have to have any > dependency on the L2 interface. My colleague Eddie Wai, is working on > this solution. This is a perfect time to discuss a common solution. > > Adding Eddie to the thread, > > Thanks again. > > -Ben > > On Wed, 2010-11-03 at 12:36 -0700, Mike Christie wrote: > > ccing Ben Li from Broadcom. > > > > > > On 11/02/2010 06:42 PM, Anish Bhatt wrote: > > > MAC addresses specified in iface files are currently case > sensitive. > > > This can be an issue on vlan interfaces, as isciadm -m iface does > not > > > create config files for vlan interfaces and they need to be written > > > manually. Attached patch will convert uppercase MAC addresses to > lower > > > case after reading them (iscsiadm expects them in lower case only). > > > > > > > > > > > > There seems to be another issue with VLAN interfaces. Interface > files > > > for offloaded vlan interfaces (on chelsio cards atleast) need a > hardware > > > address to be specified to work. As of now, iscsiadm does not catch > this > > > > So for software iscsi and vlans, you just need to specify the netdev > > vlan name (for example eth0.1 for the iface.net_ifacename). You do > not > > need to set the hwaddress/mac in the iface. > > > > iscsiadm does not catch what you need for offload because I had no > idea > > you were doing this. > > > > For chelsio offload how are you guys specifying things when vlans are > > used and what does cxgb3i export? Do you have to create a vlan with > the > > normal linux tools like vconfig first, then for the net_ifacename are > > you specifying the vlan name created by vconfig? > > cxgbi_device_find_by_netdev then matches the names with the real > netdev? > > > > Why do you need to pass in the hardware address? > > > > > > There was talk about adding a vlan id: > > http://groups.google.com/group/open- > iscsi/browse_thread/thread/7ee3b5bb5502871b/37fe62da7d1ffa4e?lnk=gst&q= > Using+IFACE_SUBNET_MASK+and+IFACE_VLAN#37fe62da7d1ffa4e > > so we could have a more common way of specifying the vlan to be used. > > > > > > > and will simply fail. This is already noted in the readme, but > would > > > > What note in the readme are you referring to? > > > > > there be any interest in adding functionality to 'iscsiadm -m > iface' to > > > handle vlan interfaces, or warn about missing hwaddress keys when > it > > > comes to offloaded vlan interfaces ? > > > > > > -Anish > > > > > > > > > > > > > > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.