On 01/07/2011 04:45 PM, k...@chelsio.com wrote:
[PATCH 1/2] cxgbi: set ulpmode only if digest is on

From: Karen Xie<k...@chelsio.com>

There is need to set ulpmode on the tx skbs if no digest is enabled.

Signed-off-by: Karen Xie<k...@chelsio.com>
---
  drivers/scsi/cxgbi/libcxgbi.c |   17 ++++++++++-------
  1 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index be56617..17dcada 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -1908,13 +1908,16 @@ EXPORT_SYMBOL_GPL(cxgbi_conn_alloc_pdu);

  static inline void tx_skb_setmode(struct sk_buff *skb, int hcrc, int dcrc)
  {
-       u8 submode = 0;
-
-       if (hcrc)
-               submode |= 1;
-       if (dcrc)
-               submode |= 2;
-       cxgbi_skcb_ulp_mode(skb) = (ULP2_MODE_ISCSI<<  4) | submode;
+       if (hcrc || dcrc) {
+               u8 submode = 0;
+
+               if (hcrc)
+                       submode |= 1;
+               if (dcrc)
+                       submode |= 2;
+               cxgbi_skcb_ulp_mode(skb) = (ULP2_MODE_ISCSI<<  4) | submode;
+       } else
+               cxgbi_skcb_ulp_mode(skb) = 0;
  }

  int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset,


Ok.

Reviewed-by: Mike Christie <micha...@cs.wisc.edu>

--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-is...@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.

Reply via email to